Pull Request Process

An overview of how we will manage old or out-of-date pull requests.

Process

We will close any pull requests older than two weeks.

Exceptions can be made for PRs that have active review comments, or that are awaiting other dependent PRs. Closed pull requests are easy to recreate, and little work is lost by closing a pull request that subsequently needs to be reopened.

We want to limit the total number of PRs in flight to:

• Maintain a clean project
• Remove old PRs that would be difficult to rebase as the underlying code has changed over time
• Encourage code velocity

Life of a Pull Request

Unless in the last few weeks of a milestone when we need to reduce churn and stabilize, we aim to be always accepting pull requests.

Either the on call manually or the submit queue automatically will manage merging PRs.

There are several requirements for the submit queue to work:

• Author must have signed CLA ("cla: yes" label added to PR)
• No changes can be made since last lgtm label was applied
• k8s-bot must have reported the GCE E2E build and test steps passed (Travis, Shippable and Jenkins build)

Additionally, for infrequent or new contributors, we require the on call to apply the "ok-to-merge" label manually. This is gated by the whitelist.

Automation

We use a variety of automation to manage pull requests. This automation is described in detail elsewhere.